CLI-1225: The pull:database command fails silently if pv is not installed. #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
============================================
+ Coverage 91.93% 91.96% +0.03%
Complexity 1820 1820
============================================
Files 124 124
Lines 6513 6513
============================================
+ Hits 5988 5990 +2
+ Misses 525 523 -2 ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR! |
Thanks for the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1640: The pull:database command fails silently if pv is not installed
Proposed changes
if pv is not installed, run gunzip with the -c flag so the decompressed output is piped to the mysql command
Alternatives considered
There are other possible ways to manage output redirection in bash, this seemed simplest.
Testing steps
On a system without pv installed set the appropriate ACLI_DB_**** environmental variables and execute an acli pull:database request. See the database downloaded and the command appear to succeed. Open the database and see that it is not empty.
./bin/acli ckc